PHP Classes

[patch]: Fix 2 small issues

Recommend this page to a friend!

      SMTP E-mail sending class  >  All threads  >  [patch]: Fix 2 small issues  >  (Un) Subscribe thread alerts  
Subject:[patch]: Fix 2 small issues
Summary:[patch]: Respect debug flag and hide warning
Messages:2
Author:Renato Botelho
Date:2016-01-18 13:58:55
 

  1. [patch]: Fix 2 small issues   Reply   Report abuse  
Picture of Renato Botelho Renato Botelho - 2016-01-18 13:58:55
These 2 small patches done in pfSense fixes following issues:

1. When CN doesn't match, stream_socket_enable_crypto() throws a PHP warning. Suppress it and only log the error that happened

github.com/pfsense/pfsense/commit/2 ...

2. Respect debug flag before call OutputDebug (maybe move the check inside function would be smarter)

github.com/pfsense/pfsense/commit/e ...

  2. Re: [patch]: Fix 2 small issues   Reply   Report abuse  
Picture of Manuel Lemos Manuel Lemos - 2016-01-19 00:19:34 - In reply to message 1 from Renato Botelho
Yes, I had already disabled debug output in some cases that were not covered but I also added your suggestion to omit errors when it is not possible to start TLS. I just uploaded the fixed version. Thanks for the suggestions.